Exclude 'off' from fanMode capability for Thermostats #2673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Invitation URL: |
Test Results 71 files 480 suites 0s ⏱️ Results for commit f0de5ed. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against f0de5ed |
nickolas-deboom
force-pushed
the
exclude-off-mode-from-fan-mode-for-thermostats
branch
from
c823475 to
f0de5ed
Compare
hcarter-775
reviewed
Jan 6, 2026
| supported_fan_modes_attribute = supported_fan_modes_capability.supportedAcFanModes | ||
| elseif device:supports_capability_by_id(capabilities.thermostatFanMode.ID) then | ||
| supported_fan_modes_attribute = capabilities.thermostatFanMode.supportedThermostatFanModes | ||
| supported_fan_modes_capability = capabilities.thermostatFanMode |
Contributor
There was a problem hiding this comment.
I'm not sure I understand why this variable was introduced. Seems like it might be adding extra complexity without reason?
Contributor
Author
There was a problem hiding this comment.
It was needed for the get_latest_state call in the logic down below. As we discussed, some of this logic won't be needed, so this variable can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes Off as a default value from supportedFanModes attribute for the Thermostat device type. Thermostats typically never support turning off the fan, but after switching from
thermostatFanModetofanModeit became an option.